Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: change datetime fields of ddl_jobs to datetime(6) #53339

Merged
merged 2 commits into from
May 17, 2024

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented May 16, 2024

What problem does this PR solve?

Issue Number: close #52919

Problem Summary:

See #52919 (comment)

What changed and how does it work?

Change field types of information_schema.ddl_jobs from datetime to datetime(6).

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    mysql> create table t (a int);
    Query OK, 0 rows affected (0.17 sec)
    
    mysql> drop table t;
    Query OK, 0 rows affected (0.32 sec)
    
    mysql> SELECT START_TIME, END_TIME, TIMEDIFF(END_TIME,START_TIME) FROM information_schema.DDL_JOBS WHERE TABLE_NAME='t';
    +----------------------------+----------------------------+-------------------------------+
    | START_TIME                 | END_TIME                   | TIMEDIFF(END_TIME,START_TIME) |
    +----------------------------+----------------------------+-------------------------------+
    | 2024-05-16 23:03:07.001000 | 2024-05-16 23:03:07.252000 | 00:00:00.251000               |
    | 2024-05-16 23:03:00.302000 | 2024-05-16 23:03:00.352000 | 00:00:00.050000               |
    +----------------------------+----------------------------+-------------------------------+
    2 rows in set (0.01 sec)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2024
Copy link

tiprow bot commented May 16, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta tangenta requested a review from dveeden May 16, 2024 15:07
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.3673%. Comparing base (b9b330a) to head (71dcabf).
Report is 18 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53339        +/-   ##
================================================
+ Coverage   72.4922%   74.3673%   +1.8751%     
================================================
  Files          1497       1524        +27     
  Lines        429929     440485     +10556     
================================================
+ Hits         311665     327577     +15912     
+ Misses        99006      92788      -6218     
- Partials      19258      20120       +862     
Flag Coverage Δ
integration 49.2399% <ø> (?)
unit 70.9379% <ø> (-0.4483%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 49.7147% <ø> (+8.2856%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2024
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dveeden, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented May 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-16 15:24:15.922512987 +0000 UTC m=+1753209.679648559: ☑️ agreed by dveeden.
  • 2024-05-17 07:00:00.430092626 +0000 UTC m=+1809354.187228199: ☑️ agreed by zimulala.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 68db9c0 into pingcap:master May 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

information_schema.DDL_JOBS has wrong results for time columns
4 participants