Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add rpc error stats and refine log for diagnose #53335

Merged
merged 10 commits into from
May 21, 2024
Merged

*: add rpc error stats and refine log for diagnose #53335

merged 10 commits into from
May 21, 2024

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented May 16, 2024 •
edited

What problem does this PR solve?

Issue Number: close #52809

Related PR: tikv/client-go#1340
Provide related enhancements for the stand-alone branch.

What changed and how does it work?

This PR cherry-pick following PR:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

zyguan and others added 9 commits January 10, 2024 19:33
@zyguan
sessionctx: add sysvar to control exp feats of replica selector
df798a8 
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@crazycs520
update client-go
01e95af 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
*: add rpc error stats and refine log (pingcap#52810)
1cb8533 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
store: refine coprocessor error log (pingcap#52729)
312d100 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
*: improve log about stale-read query (pingcap#52494)
773de8f 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
*: refine tikv/client-go log to print context information(such as con…
7c4f34a 
…n id) as much as possible (pingcap#45559)

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
add leader peer id log
c1d0657 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
update log
a1b81e7 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
executor: fix issue that some query execution stats was omitted when …
9882f6a 
…execution was interrupted (pingcap#51787)

close pingcap#51660

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2024
@tiprow tiprow
Copy link

tiprow bot commented May 16, 2024

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cfzjywxk
Copy link
Contributor

@crazycs520 Is it reviewable by now?

@crazycs520 crazycs520 marked this pull request as ready for review May 21, 2024 06:09
@crazycs520 crazycs520 requested a review from a team as a code owner May 21, 2024 06:09
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2024
@crazycs520
Copy link
Contributor Author

@crazycs520 Is it reviewable by now?

yes.

cfzjywxk
cfzjywxk reviewed May 21, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@crazycs520
update go.mod
f5af885 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 21, 2024

@crazycs520: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test f5af885 link true /test mysql-test
idc-jenkins-ci-tidb/unit-test f5af885 link true /test unit-test
idc-jenkins-ci-tidb/check_dev f5af885 link true /test check-dev
idc-jenkins-ci-tidb/check_dev_2 f5af885 link true /test check-dev2
idc-jenkins-ci-tidb/build f5af885 link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-21 08:47:37.694157815 +0000 UTC m=+2161411.451293388: ☑️ agreed by cfzjywxk.

@cfzjywxk cfzjywxk merged commit 4be26db into pingcap:tidb-6.5-with-kv-timeout-feature May 21, 2024
1 of 7 checks passed
mittalrishabh pushed a commit to mittalrishabh/tidb that referenced this pull request May 30, 2024
@crazycs520 @zyguan
Cherrypick : add rpc error stats and refine log for diagnose (pingcap…
5ca1a96 
…#53335) (pingcap#96)

* *: add rpc error stats and refine log for diagnose (pingcap#53335)

* sessionctx: add sysvar to control exp feats of replica selector

Signed-off-by: zyguan <zhongyangguan@gmail.com>

* *: add rpc error stats and refine log (pingcap#52810)

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* store: refine coprocessor error log (pingcap#52729)

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* *: improve log about stale-read query (pingcap#52494)

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* *: refine tikv/client-go log to print context information(such as conn id) as much as possible (pingcap#45559)

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* add leader peer id log

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* update log

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* executor: fix issue that some query execution stats was omitted when execution was interrupted (pingcap#51787)

close pingcap#51660

Signed-off-by: crazycs520 <crazycs520@gmail.com>

* update go.mod

Signed-off-by: crazycs520 <crazycs520@gmail.com>

---------

Signed-off-by: zyguan <zhongyangguan@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Co-authored-by: zyguan <zhongyangguan@gmail.com>

* Update go.sum

* Update go.mod

---------

Signed-off-by: zyguan <zhongyangguan@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Co-authored-by: crazycs <crazycs520@gmail.com>
Co-authored-by: zyguan <zhongyangguan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees
No one assigned
Labels
approved needs-1-more-lgtm release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crazycs520 @cfzjywxk @zyguan