Fix Query Generator IS NULL / IS NOT NULL
#19163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: faissaloux <fwahabali@gmail.com>
faissaloux
force-pushed
the
fix-query-generator-is-null
branch
from
7f7a0c8
to
2590313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hellooo 👋🏻
In this PR I fixed the bug in the
Query Generatorthat generates a non-valid query when usingIS NULLandIS NOT NULL.Before
As you can see it adds the criteria string before
IS NULLwhich is empty in this case (Same thing forIS NOT NULL).Which is not a valid query. ❌
After
Valid ✅
Hide criteria when the op doesn't need it.
Screencast.from.14-05-24.21.53.10.webm
Server configuration