Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export and drop triggers in a single POST request #18999

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IAndreyI
Copy link
Contributor

Description

This PR makes "Export" and "Drop" multiple triggers more quick. These actions perform in a single post request.

Fixes #18556

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 98.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.86%. Comparing base (3acf78d) to head (7b441ac).
Report is 281 commits behind head on master.

Files Patch % Lines
src/Controllers/Triggers/IndexController.php 97.36% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18999      +/-   ##
============================================
+ Coverage     58.83%   58.86%   +0.03%     
- Complexity    15929    15941      +12     
============================================
  Files           667      667              
  Lines         61329    61374      +45     
============================================
+ Hits          36081    36127      +46     
+ Misses        25248    25247       -1     
Flag Coverage Δ
dbase-extension 58.86% <98.00%> (+0.03%) ⬆️
unit-8.1-ubuntu-latest 58.82% <98.00%> (+0.03%) ⬆️
unit-8.2-ubuntu-latest 58.79% <98.00%> (+0.03%) ⬆️
unit-8.3-ubuntu-latest 58.79% <98.00%> (+0.03%) ⬆️
unit-8.4-ubuntu-latest 58.79% <98.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAndreyI IAndreyI force-pushed the export-in-a-single-POST-request branch from ab64ffd to 126e12c Compare February 21, 2024 04:00
Signed-off-by: Petrichenko Andrey <1993czar@gmail.com>
@IAndreyI IAndreyI force-pushed the export-in-a-single-POST-request branch from 126e12c to 7b441ac Compare February 22, 2024 06:01
@IAndreyI IAndreyI marked this pull request as ready for review February 22, 2024 06:16
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this and fix this crash PHP Fatal error: A function with return type must return a value (did you mean "return null;" instead of "return;"?) in src/Controllers/Triggers/IndexController.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve multiple triggers export/drop
2 participants