Fixes null @ currentBatch due flush() calls @ LightPipeline.js #6822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next test scenario might reveal an exception/crash due null values at currentBatch property of LightPipeline:
1) Mesh gameobject -> .setPipeline('Light2D')
2) Applying a rotation to the mesh
2) Crash flow: MeshWebGLRenderer -> setGameObject -> setNormalMapRotation -> flush
Rationale: setGameObject @ MeshWebGLRenderer invoking a flush @ setNormalMapRotation and making currentBatch=null.
The crash happens @ MeshWebGLRenderer once reading a property on currentBatch (null).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: Fixes a bug
Test scenario:
The test might reveal an exception/crash due null values at currentBatch property of LightPipeline.
Crash flow: MeshWebGLRenderer -> setGameObject -> setNormalMapRotation -> flush
Rationale: setGameObject @ MeshWebGLRenderer invoking a flush @ setNormalMapRotation and making currentBatch=null.
The crash happens @ MeshWebGLRenderer once reading a property on currentBatch (null).