Fix #576 #579
Open
Fix #576 #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
decebals
commented
Apr 6, 2024
| @@ -331,6 +331,9 @@ protected boolean unloadPlugin(String pluginId, boolean unloadDependents) { | |||
| } | |||
| } | |||
|
|
|||
| // resolve the plugins again (update plugins graph) | |||
| resolveDependencies(); | |||
There was a problem hiding this comment.
Here, I have some uncertainties regarding performance (the case in which a recursive unload is made => resolveDependencies method is called several times)
There was a problem hiding this comment.
Hi @decebals , Can we update the dependencies graph by providing a method similar to void removePlugin(PluginDescriptor descriptor) in DependencyResolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.