-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hugging_face): Add support for multiple models and dimensions #624
feat(hugging_face): Add support for multiple models and dimensions #624
Conversation
@bricesanchez Thank you for the PR, looks like the specs are failing. |
@andreibondarev You're right! It looks like elasticsearch class looks like for the LLM dimensions (lib/langchain/vectorsearch/elasticsearch.rb:107). But it looks like there is no I can re-add it for simplicity. What do you think? |
@bricesanchez Take a look at how we do it in the Ollama integration: langchainrb/lib/langchain/llm/ollama.rb Lines 53 to 59 in b3a1b65
|
bd23d0d
to
ae4b051
Compare
@andreibondarev, I've made the changes, don't hesitate if you have any comments! |
@bricesanchez Thank you! Left you a comment. |
9333ac4
to
e9b3240
Compare
@bricesanchez I'm going to review it shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bricesanchez Thank you for the PR! Looks great!
Thank you @andreibondarev! |
Hello! Thank you for this awesome gem!
I'm currently playing with it and i've seen Hugging face ruby gem can now support custom embedding models:
see: alchaplinsky/hugging-face@bee85a4
I've added the ability to change the embedding model and did some clean up in the class.