ci(oxlint): add oxc_language_server binary to the oxlint package.
#3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rzvxa
force-pushed
the
05-19-ci_oxlint_add_oxls_binary_to_the_oxlint_package
branch
from
2a3b95e
to
4230de1
Compare
rzvxa
changed the title
oxls binary to the oxlint package.oxc_language_server binary to the oxlint package.
|
@Boshen I'm sure we pretty soon want to separate them into their own packages, but do you think it would be fine for now? |
rzvxa
commented
May 20, 2024
Boshen
force-pushed
the
05-19-ci_oxlint_add_oxls_binary_to_the_oxlint_package
branch
from
5cde082
to
bae9eeb
Compare
Merge activity
|
…#3350) I didn't introduce a new set of native packages for the `oxc_language_server` binary, This change temporarily bundles them as part of oxlint, We most probably would want to make it an optional dependency in the future if we start to add more futures like formatting, jump to definition, etc to it.
Boshen
force-pushed
the
05-19-ci_oxlint_add_oxls_binary_to_the_oxlint_package
branch
from
bae9eeb
to
56cbdf5
Compare
graphite-app
bot
deleted the
05-19-ci_oxlint_add_oxls_binary_to_the_oxlint_package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't introduce a new set of native packages for the
oxc_language_serverbinary, This change temporarily bundles them as part of oxlint, We most probably would want to make it an optional dependency in the future if we start to add more futures like formatting, jump to definition, etc to it.