Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Contact Information field in Marketing Lists #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sad270
Copy link

@sad270 sad270 commented Nov 5, 2019

Need this fix oroinc/platform#968 for working

The Account Contact Information virtual field doesn't work in MarketingList

I create new marketing list with Account entity and add Contact Information field (this field should return the primary email of default contact)

Capture d’écran - 2019-11-05 à 14 33 04

And Contact Information field is empty

Capture d’écran - 2019-11-05 à 14 33 29

In entity.yml we can see that the fields return the email field of defaultContact. Contact::email is inherited from BasePerson and not used.

@orocla
Copy link

orocla commented Nov 5, 2019

Thank you for your pull request.

It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocrm.com/contributor-license-agreement/

If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits.

Once you've signed the CLA, please allow for some time for the submission to be processed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants