[editor] Limit more fields (website, menu, social medias, etc...) for some POI types #8212
Conversation
Arthur-GYT
force-pushed
the
fix_website_menu
branch
2 times, most recently
from
56b8b9e
to
60655a3
Compare
|
The right solution is to update editor.config |
Arthur-GYT
force-pushed
the
fix_website_menu
branch
from
60655a3
to
eb20b22
Compare
|
@Jean-BaptisteC It's strange. I test it with restaurant and it appear for haircut. Do I miss something ? EDIT : I found the problem. My mistake ^^. |
Arthur-GYT
force-pushed
the
fix_website_menu
branch
from
c36763b
to
63c161c
Compare
Arthur-GYT
force-pushed
the
fix_website_menu
branch
from
63c161c
to
c4aa57e
Compare
Arthur-GYT
force-pushed
the
fix_website_menu
branch
from
c4aa57e
to
b3b5217
Compare
Arthur-GYT
force-pushed
the
fix_website_menu
branch
from
b3b5217
to
3b56dd7
Compare
Arthur-GYT
changed the title
Arthur-GYT
changed the title
|
@biodranik I've changed the scope of the PR. I've also fixed the fact that, for example, parking lots were displaying fields for social medias in the editor (which doesn't make sense). |
| mDetailsBlocks.put(Metadata.MetadataType.FMD_WEBSITE_MENU, websiteMenuBlock); | ||
| mDetailsBlocks.put(Metadata.MetadataType.FMD_EMAIL, emailBlock); | ||
| mDetailsBlocks.put(Metadata.MetadataType.FMD_CONTACT_FACEBOOK, facebookContactBlock); | ||
| mDetailsBlocks.put(Metadata.MetadataType.FMD_CONTACT_INSTAGRAM, instagramContactBlock); |
There was a problem hiding this comment.
Previously, it ignored the configuration described in editor.config. You need to add the field as shown here to make it take this configuration into account.
There was a problem hiding this comment.
@biodranik Do I need to change anything?
android/app/src/main/java/app/organicmaps/editor/EditorFragment.java
Outdated
Show resolved
Hide resolved
Arthur-GYT
force-pushed
the
fix_website_menu
branch
2 times, most recently
from
41f43b3
to
9bfcd94
Compare
Signed-off-by: Arthur-GYT <a.gayot@posteo.com>
Arthur-GYT
force-pushed
the
fix_website_menu
branch
from
9bfcd94
to
74a01c1
Compare
There was a problem hiding this comment.
LGTM, Did you test it? Note that debug build of OM uploads data into the dev server, and you need a separate account there:
https://master.apis.dev.openstreetmap.org/
If you need to edit some data from the main OSM server, you can upload it to the dev server using this tool: https://github.com/Zverik/osm_to_sandbox
@Jean-BaptisteC PTAL if you have time.
There was a problem hiding this comment.
✅ Pixel 6 - Android 14
https://master.apis.dev.openstreetmap.org/node/4349085700
All is in the title ^^.
Related to #8052 (comment)