-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] better user profile (initial layout) #8192
[android] better user profile (initial layout) #8192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That is a good start.
android/app/build.gradle
Outdated
@@ -393,6 +393,8 @@ dependencies { | |||
implementation 'com.google.guava:guava:33.1.0-android' | |||
implementation 'com.github.devnullorthrow:MPAndroidChart:3.2.0-alpha' | |||
implementation 'net.jcip:jcip-annotations:1.0' | |||
// Used for circular profile image in profile | |||
implementation 'de.hdodenhof:circleimageview:3.1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a square image be enough? It would be great to avoid non-critical dependencies.
android/app/src/main/java/app/organicmaps/editor/ProfileFragment.java
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,7 @@ | |||
<vector xmlns:android="http://schemas.android.com/apk/res/android" android:height="105.34979dp" android:viewportHeight="1280" android:viewportWidth="1215" android:width="100dp"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How a user Material icon looks compared to this one? https://fonts.google.com/icons?selected=Material%20Symbols%20Outlined%3Aperson%3AFILL%401%3Bwght%40400%3BGRAD%400%3Bopsz%4024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6ec118d
to
2c7471b
Compare
|
it won't, i didn't think it needed to be bigger but i'll make it scale to fit.
Definitely, however it makes more sense to implement this when displaying a user profile picture is actually done, otherwise it'll confuse users |
2c7471b
to
41c5143
Compare
Thanks! Can the title (OpenStreetMap Profile) be somehow autoscrolled when its too large? How Android usually solve this issue in other places? |
41c5143
to
503f5ed
Compare
Reworked again to make text always fit (looks mostly the same)
This is an issue with headers across the app, so I'll open a separate issue for it. There's a marquee scroll effect which we could use, but maybe a better fix would be to use a shorter string when there are larger font sizes (OpenStreetMap Profile -> OSM Profile) edit: issue opened at #8324 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits.
android/app/src/main/java/app/organicmaps/editor/ProfileFragment.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Harry Bond <me@hbond.xyz>
503f5ed
to
d169b9e
Compare
fixed nits :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Some work towards a better user profile page.
Sadly i'm gonna be really busy for the next couple of months, so loading the profile image will have to wait (although it's somewhat working at redauburn/organicmaps/android-user-profile, albeit in the wrong place...)
i thought i may as well submit this stripped down version though, which has a new user info layout, displays the username, and formats the changeset count according to locale.
before/after:
generic profile image from https://svgsilh.com/image/378368.html (CC0)