[classif] Move low use highway=road to a higher ID #8181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biodranik
reviewed
May 16, 2024
| @@ -93,8 +93,7 @@ highway|primary;27; | |||
| railway|rail;28; | |||
| highway|service|parking_aisle;[highway=service][service=parking_aisle];;name;int_name;29; | |||
| place|hamlet;30; | |||
| # TODO: 50k usages, move | |||
| highway|road;31; | |||
| moved:highway|road:05.2024;31;highway|road | |||
There was a problem hiding this comment.
date when it was moved/deprecated
so that we know when its OK to re-use it
vng
reviewed
May 19, 2024
| @@ -54,7 +54,7 @@ enum class HighwayType : uint16_t | |||
| HighwaySecondaryLink = 176, | |||
| RouteFerry = 259, | |||
| HighwayTertiaryLink = 272, | |||
| HighwayBusway = 858, // reserve type here, but this type is not used for any routing by default | |||
| HighwayBusway = 857, // reserve type here, but this type is not used for any routing by default | |||
There was a problem hiding this comment.
Why? I don't see changes in types.txt here.
Can we make a test for these constants, not to break something in future? :)
There was a problem hiding this comment.
Its just wrong, it should be a mapping ID - 1, so atm the hardcoded 858 points to highway-busway-bridge
highway|busway;[highway=busway],[highway=service][service=busway],[highway=service][service=bus];;name;int_name;858;
highway|busway|bridge;[highway=busway][bridge?];;name;int_name;859;
|
You are right, it was moved several times. Please, add cpp test for these constants, or I can do it? |
Add it please! |
|
@vng merge it as is? |
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
vng
force-pushed
the
pastk-classif-move-highway-road
branch
from
bbfc0d4
to
f19401f
Compare
vng
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #8168
Also fixes wrong hardcoded ID for highway=busway.