-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[styles] Add rendering for road area:highway #8175
base: master
Are you sure you want to change the base?
Conversation
See organicmaps#7207 Signed-off-by: Romi Jokela <jokelaromi@gmail.com>
Signed-off-by: Romi Jokela <jokelaromi@gmail.com>
Signed-off-by: Romi Jokela <jokelaromi@gmail.com>
Thanks!
|
Hi, Linear features are still rendered as before, and provide a convenient source and centerline target for labels and one-way arrows on roads with mapped As for issues, I could not seem to apply an area rendering style to the non |
I don't really like it. It's inconsistent with the rendering of area:highway=footway, for which a way less intrusive background shade is used. |
Yeah my opinion is the same, Also supporting the tag would prompt people to map highways as areas, complicating updating roads everywhere. If you want highways as areas, just add imagery. |
While I do agree that it a high workload tag to support, I find the idea that aerial imagery is a simple replacement for it unconvincing. Single source satellite imagery tends to have a very variable quality, trending towards unusable in northern latitudes. Similarly I find supporting displaying tagged areas where they are present meaningful in the same way that displaying landcover data is meaningful, as a complete map. The use case is having an accurate picture of the environment you are navigating while still having the visual abstraction of a map. |
On imagery, how do you map highway areas on OSM when the imagery is missing? It's not something you can survey and bring home. Well, apart from professional surveying with teodolytes, which is typically not done for OSM. |
By using local high quality aerial imagery that is not really suitable as-is for consumer map use (think without manual setup per city). That being said I don't think the process requirements of mapping a specific tag is in scope for discussion on a PR for rendering it. |
I like it, maybe it can only be rendered at high zooms? |
We should also consider that adding those to the style increases the download size for maps. If we have few highway areas, they would look out-of-place, unexpected. If we have many, the download size would grow and we need to rationalize the benefit of having those, besides "anything present on the map helps navigating". |
I have my doubts that the area:highway dataset would result in a meaningful increase in storage usage. |
How about rendering of road width then? I think it'd be really cool/useful to display lanes & markings etc. |
It would be great to focus our energy on important and beneficial features/improvements that help/target most of our users in the first place. Ilya mentioned several cons already. I would add a slower map rendering here too. Faster map downloads/updates are also critical to reach an experience comparable with Google or Apple maps in the future. It would be great to keep OM's focus on its simplicity, speed, lightweight, and low battery usage. Rendering width is a great idea btw, is it widely used? |
It seems to me |
You're very unlikely to see physically accurate lane markings on any OSM project for a long while, if ever. |
I was thinking of an approximate representation, such as divide width (obtained by geometry) by number of lanes ( |
This PR covers the area:highway half of #7207 and adds rendering for values of
area:highway=
matching most public roads:motorway
motorway_link
trunk
trunk_link
primary
primary_link
secondary
secondary_link
tertiary
tertiary_link
unclassified
residential
The priorities and style colors are all matched with the respective
highway=
tags.Current state of the PR is with the styles sequestered in their own
/clear/include/Road_areas.mapcss
file, which is relatively imported in the other styles'style.mapcss
files.highway-footway
,highway-footway-area
, andhighway-footway-bicycle
priorities have been bumped up to make sure they are still visible when crossing a highway area.This PR also contains a style rule for
[highway=pedestrian][area],
but that seems to need further work before it works correctly.Example of an area with full area:highway coverage
Example of an area with partial area:highway coverage.
Example of a layered area.