Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[strings] Fixed Portuguese exit strings #8150

Merged
merged 2 commits into from
May 19, 2024

Conversation

matheusgomesms
Copy link
Contributor

Quick fix: fixed Portuguese exit (entrance/door) strings.

Although PT and PT-BR translations are the same, since it seems OM is moving translations to Weblate, I preferred to have it duplicated. Let's see how it works in the future.

Signed-off-by: Matheus Gomes <86851490+matheusgomesms@users.noreply.github.com>
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to weblate is not approved yet, the quality of translations there, unfortunately, is not great, and it may seriously complicate development and adding translation strings by collaborators.

data/strings/types_strings.txt Outdated Show resolved Hide resolved
@matheusgomesms
Copy link
Contributor Author

I'm talking about #4515, don't how it will be with same strings as EN, same strings related to PT/PT-BR and ES/ES-MX for example... Even though, fixing here now!

Signed-off-by: Matheus Gomes <86851490+matheusgomesms@users.noreply.github.com>
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obrigado!

@biodranik biodranik merged commit 2d421bd into organicmaps:master May 19, 2024
4 checks passed
@matheusgomesms matheusgomesms deleted the pt-exit branch May 19, 2024 21:11
kavikhalique pushed a commit to kavikhalique/organicmaps that referenced this pull request May 25, 2024
* Fixed PT exit strings

Signed-off-by: Matheus Gomes <86851490+matheusgomesms@users.noreply.github.com>

* Remove duplicate

Signed-off-by: Matheus Gomes <86851490+matheusgomesms@users.noreply.github.com>

---------

Signed-off-by: Matheus Gomes <86851490+matheusgomesms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants