Fixes #20215: Fix invalid translation count

[masterboy376]

Overview

1. This PR fixes or fixes part of Invalid translation counts in the ExplorationOpportunityModel #20215.
2. This PR does the following: brings translation count in ExplorationOpportunity model and actual number of translations into sync with each other. Also here is before and after analysis of translation count Doc.
3. (For bug-fixing PRs only) The original bug occurred because: Firstly, here in PR #16352 we were not removing the entity translations even after the content is removed while updating the exploration. Secondly, in this commit when reverting the exploration, we were not using the translations already submitted by the users for the version, we were reverting to and also, we were not updating the translation count in this case in ExplorationOpportunity model.

Essential Checklist

Please follow the instructions for making a code change.

• I have linked the issue that this PR fixes in the "Development" section of the sidebar.
• I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
• I have written tests for my code.
• The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
• I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

screen-recorder-fri-may-17-2024-09-38-56.webm

Proof of changes on desktop with slow/throttled network

screen-recorder-fri-may-17-2024-09-38-56.webm

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

• Never force push! If you do, your PR will be closed.
• To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
• Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
• See the Code Owner's wiki page for what code owners will expect.

[oppiabot]

Hi @masterboy376 please assign the required reviewer(s) for this PR. Thanks!

[masterboy376]

@vojtechjelinek , @chris7716 , @lkbhitesh07 PTAL

[oppiabot]

Unassigning @masterboy376 since a re-review was requested. @masterboy376, please make sure you have addressed all review comments. Thanks!

[vojtechjelinek]

Thanks! Took a pass.

[vojtechjelinek]

Hmm, interesting how many things are added here. Can you please check whether all these changes are expected?

[masterboy376]

Am, after checking of them individually, I found that each of them is directly or indirectly related to the exploration related fields. Still, I feel like some of them are unnecessary. This file is generated automatically, right? So, if I delete the newly added line and perform reverting of an exploration on local dev server then lines which are absolutely necessary should be added again. Should I try this ?

[vojtechjelinek]

Yes, it should work that way, please try it and see what happens.

[oppiabot]

Unassigning @vojtechjelinek since the review is done.

[oppiabot]

Hi @masterboy376, it looks like some changes were requested on this pull request by @vojtechjelinek. PTAL. Thanks!

[masterboy376]

@vojtechjelinek PTAL

[oppiabot]

Unassigning @masterboy376 since a re-review was requested. @masterboy376, please make sure you have addressed all review comments. Thanks!