Fix part of #18384: Reusable carousel component for learner dashboard redesign #20306
Conversation
|
Assigning @Nik-09 for the first pass review of this PR. Thanks! |
amyyeung17
changed the title
|
Hi @amyyeung17, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. |
|
@Nik-09 PTAL |
|
Sorry @amyyeung17 for the delay. I will take a look tomorrow morning. Thank you |
There was a problem hiding this comment.
Thank you @amyyeung17 for the PR, I have added a few comments, PTAL.
Also sorry for the delayed review.
Thanks
| @@ -41,6 +41,7 @@ export class LearnerTopicSummaryTileComponent implements OnInit { | |||
| thumbnailBgColor!: string; | |||
| openInNewWindow = false; | |||
| @Input() redesignFeatureFlag!: boolean; | |||
| @Input() last!: boolean; | |||
There was a problem hiding this comment.
This is a very generic name, can you please help me to understand what does this mean?
| @@ -34,6 +34,7 @@ import {StoryNode} from 'domain/story/story-node.model'; | |||
| export class LessonCardComponent implements OnInit { | |||
| @Input() story!: StorySummary | LearnerExplorationSummary | CollectionSummary; | |||
| @Input() topic!: string; | |||
| @Input() last!: boolean; | |||
| import {downgradeComponent} from '@angular/upgrade/static'; | ||
|
|
||
| @Component({ | ||
| selector: 'card-display', |
There was a problem hiding this comment.
Can we make the selector name oppia-card-display to make the component consistent throughout the codebase?
Overview
This PR addresses part of the 3rd breakpoint of #18384, adding a new reusable carousel component.
Includes 3 new files:
Additional notes:
Essential Checklist
Please follow the instructions for making a code change.
Proof that changes are correct
final-carousel.mov