-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge new branch with updated read me #1516
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @KaizenGirl1111! It looks like this is your first PR to openkruise/kruise 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1516 +/- ##
==========================================
- Coverage 49.21% 49.19% -0.03%
==========================================
Files 157 157
Lines 22604 22604
==========================================
- Hits 11125 11119 -6
- Misses 10268 10272 +4
- Partials 1211 1213 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@KaizenGirl1111 Good Job, and can you resolve the check fails, for example: |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Ⅰ. Describe what this PR does
I just added a table comparing native kubernetes and kubernetes extended with OpenKruise
Ⅱ. Does this pull request fix one issue?
No, it doesn't fix any prevailing issue
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
This is a PR in special attempt to understand OpenKruise project and is maybe a very naive one :) I am all ears to reviews. I have also applied for LFX this year, if I get selected would love to learn more. I also published an interesting article explaining OpenKruise in simple words like explaining to a 5 year old - https://avniuplabdhee.hashnode.dev/openkruise-explained-like-you-are-5