Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inplace-update restart count #1097

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

diannaowa
Copy link
Contributor

Ⅰ. Describe what this PR does

Add inPlaceUpdate restart count to annotation.
the result is shown below:
Annotations:

apps.kruise.io/inplace-update-containers-restart-count: '{"nginx":{"revision":"sample-d97f89dcf","restartCount":1,"timestamp":"2022-03-24T08:03:23Z"},"sidecar":{"revision":"sample-d97f89dcf","restartCount":1,"timestamp":"2022-03-24T08:03:23Z"}}'
apps.kruise.io/inplace-update-pod-restart-count: "2"

apps.kruise.io/inplace-update-pod-restart-count: The Pod restart count.
apps.kruise.io/inplace-update-containers-restart-count: Every container restart count of the pod.
(revision: the revision of the container updated.)

The revision and timestamp maybe is different between the containers when we just update one(or a part of containers in the pod) container of the pod.Because we just update the restart count of the container when it will be updated(inplace-update).

Ⅱ. Does this pull request fix one issue?

fixes #910

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot added the size/L size/L: 100-499 label Oct 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Attention: Patch coverage is 53.19149% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 49.31%. Comparing base (209d476) to head (67b3c7c).

❗ Current head 67b3c7c differs from pull request most recent head bc70823. Consider uploading reports for the commit bc70823 to get more accurate results

Files Patch % Lines
pkg/util/inplaceupdate/inplace_update.go 53.19% 16 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
+ Coverage   47.82%   49.31%   +1.49%     
==========================================
  Files         161      137      -24     
  Lines       23395    19334    -4061     
==========================================
- Hits        11188     9535    -1653     
+ Misses      10993     8743    -2250     
+ Partials     1214     1056     -158     
Flag Coverage Δ
unittests 49.31% <53.19%> (+1.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@furykerry furykerry requested a review from zmberg October 18, 2022 02:56
@FillZpp
Copy link
Member

FillZpp commented Oct 24, 2022

@diannaowa How about a discussion on the community meeting this Thursday? You can add this topic into the agenda https://shimo.im/docs/gXqmeQOYBehZ4vqo

@zmberg zmberg added this to In progress in Roadmap via automation Jan 5, 2023
@zmberg zmberg added this to the v1.4 milestone Jan 5, 2023
@zmberg
Copy link
Member

zmberg commented Jan 5, 2023

#910

@zmberg zmberg removed this from In progress in Roadmap Jan 5, 2023
@zmberg zmberg removed this from the v1.4 milestone Feb 14, 2023
@zmberg zmberg added this to In progress in Roadmap via automation Feb 14, 2023
@zmberg zmberg self-assigned this Feb 14, 2023
@zmberg zmberg added this to the v1.5 milestone Jun 8, 2023
@zmberg zmberg modified the milestones: v1.5, 1.6, 1.7 Mar 7, 2024
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zmberg by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: liuzhenwei <dui_zhang@163.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: liuzhenwei <dui_zhang@163.com>
Signed-off-by: Liu Zhenwei <zwliu@thoughtworks.com>
Signed-off-by: liuzhenwei <dui_zhang@163.com>
Signed-off-by: liuzhenwei <dui_zhang@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L size/L: 100-499
Projects
Roadmap
  
In progress
Development

Successfully merging this pull request may close these issues.

[feature request] add inPlaceUpdate restart count to annotation
6 participants