Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] add inPlaceUpdate restart count to annotation #910

Open
szy441687879 opened this issue Feb 23, 2022 · 5 comments · May be fixed by #1097
Open

[feature request] add inPlaceUpdate restart count to annotation #910

szy441687879 opened this issue Feb 23, 2022 · 5 comments · May be fixed by #1097
Assignees
@diannaowa
Labels
kind/feature-request kind/good-first-issue Good for newcomers kind/good-idea Good Idea
Projects
Roadmap
Milestone
1.7

Comments

@szy441687879
Copy link

What would you like to be added:
Add inPlaceUpdate restart count to annotation
Why is this needed:
Our developers use restartCount as a way to judge the status of service, but inPlaceUpdate or Container Restart will add restart count, it may make them confused.
Since it hard to change the logic of pod restart count, it's also useful to add restart Caused by kruise in annotation, then handle this in ui。
@FillZpp FillZpp added this to Proposal in Roadmap via automation Feb 23, 2022
@FillZpp
Copy link
Member

FillZpp commented Feb 23, 2022

@szy441687879 Thanks! I'm thinking should the inPlaceUpdate restart count in annotation to be the count of whole pod or the counts of each containers in pod?

@szy441687879
Copy link
Author

@FillZpp In our scene, the count of whole pod is enough.But record the count of each containers may be more consistent with pod status.

@FillZpp FillZpp moved this from Proposal to To do in Roadmap Mar 7, 2022
@FillZpp
Copy link
Member

FillZpp commented Mar 7, 2022

/assign @szy441687879

@diannaowa
Copy link
Contributor

diannaowa commented Mar 24, 2022 •
edited

I implemented this in my own environment and the result is shown below：
Annotations:

apps.kruise.io/inplace-update-containers-restart-count: '{"nginx":{"revision":"sample-d97f89dcf","restartCount":1,"timestamp":"2022-03-24T08:03:23Z"},"sidecar":{"revision":"sample-d97f89dcf","restartCount":1,"timestamp":"2022-03-24T08:03:23Z"}}'
apps.kruise.io/inplace-update-pod-restart-count: "2"

apps.kruise.io/inplace-update-pod-restart-count: The Pod restart count.
apps.kruise.io/inplace-update-containers-restart-count: Every container restart count of the pod.
(revision: the revision of the container updated.)

The revision and timestamp maybe is different between the containers when we just update one(or a part of containers in the pod) container of the pod.Because we just update the restart count of the container when it will be updated(inplace-update).
create a PR for this issue.

@diannaowa diannaowa mentioned this issue Mar 25, 2022
Closed
@chenshiwei-io
Copy link

Is there any progress on this issue?

@diannaowa diannaowa linked a pull request Oct 7, 2022 that will close this issue
Open
@zmberg zmberg moved this from To do to In progress in Roadmap Jan 5, 2023
@zmberg zmberg added kind/good-first-issue Good for newcomers kind/good-idea Good Idea labels Feb 22, 2023
@zmberg zmberg assigned diannaowa and unassigned FillZpp and szy441687879 Jun 8, 2023
@zmberg zmberg added this to the v1.5 milestone Jun 8, 2023
@zmberg zmberg modified the milestones: v1.5, 1.6, 1.7 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diannaowa diannaowa

Labels
kind/feature-request kind/good-first-issue Good for newcomers kind/good-idea Good Idea
Projects
Roadmap
  
In progress
Milestone
1.7
5 participants
@FillZpp @szy441687879 @diannaowa @zmberg @chenshiwei-io