Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure openai #1667

Closed

Conversation

algorithmlover2016
Copy link

Pull Request Checklist

  • Description: Briefly describe the changes in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?

Description

[Insert a brief description of the changes made in this pull request]


Changelog Entry

Added

  • [List any new features or additions]

Fixed

  • [List any fixes or corrections]

Changed

  • [List any changes or updates]

Removed

  • [List any removed features or files]

@tjbck tjbck marked this pull request as draft April 22, 2024 14:54
@Micahelb
Copy link

Micahelb commented May 9, 2024

@algorithmlover2016

have you tested this changes to add Azure Open AI? Have they worked for you?

@algorithmlover2016
Copy link
Author

Yeah, I test it by myself, But now I think it's better to use litlellm to support azure openai, not by my way. It's a little complex and stupid.

@algorithmlover2016 algorithmlover2016 deleted the add_azure_openai branch May 12, 2024 12:45
@algorithmlover2016 algorithmlover2016 restored the add_azure_openai branch May 12, 2024 12:46
@frandominguezl
Copy link

Hi @algorithmlover2016, I was following your solution and was also thinking about opening a new PR given that yours was still in draft. Could you please elaborate further on why do you think it's complex to add Azure OpenAI support?

@tjbck tjbck mentioned this pull request May 16, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants