add _defaultApiClient in api/client.go for reuse #4096
Closed
+50
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwqx
changed the title
alwqx
changed the title
alwqx
force-pushed
the
feat/default-api-client-reuse
branch
from
5085172
to
75c5080
Compare
alwqx
changed the title
alwqx
changed the title
alwqx
force-pushed
the
feat/default-api-client-reuse
branch
2 times, most recently
from
e42a23b
to
821864d
Compare
alwqx
force-pushed
the
feat/default-api-client-reuse
branch
from
821864d
to
c55c01f
Compare
alwqx
changed the title
alwqx
changed the title
|
Hi @alwqx thanks for the PR! I do think this might not be as big of a deal as we think as the http clients in Go should be relatively lightweight, and so to keep things simple we can probably just re-create it every time. |
|
I understand, thanks for your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this pr mainly make following improvements:
I find that
api.ClientFromEnvironment()is called more than one time by some functions incmd/cmd.go(e.g.RunHandler()generateInteractive). So I add _defaultApiClient for reuse and to reduce memory alloc.TestClientFromEnvironmenttoTestClientFromEnvironmentandTestGetOllamaHostI hope these improvements are helpful. @jmorganca @dhiltgen Please feel free to provide feedback if you have any suggestions. And if you think this pr is not needed, I will close it.