-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add py.typed to mark the library as typed #129
Conversation
Removes an error like this: error: Skipping analyzing "ollama": module is installed, but missing library stubs or py.typed marker [import-untyped] when running mypy over code that uses the library.
@jmorganca Any updates on this? It is quite hard to tell who the maintainer of this project is. |
I don't use poetry but I would be very surprised if it doesn't automatically include |
@bpshaver You may be right, but I remember us needing to do this to convince Poetry to include it when building Textual; perhaps that's changed in the last year or so? |
Just did a test build without the |
@davep I'm happy to merge this if you can remove the pyproject.toml change since poetry includes it |
If I can? Did a word get missed? Sorry, don't quite understand what's being asked. |
I missed a word "remove" |
Ahh! Got you! Sure, I'll sort that when I'm next at a keyboard (hopefully within the next hour). |
@mxyng Done! |
Removes an error like this:
when running mypy over code that uses the library.