Answered important source code question. #7596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Coby. Thanks for your PR but this seems redundant and unnecessary. |
|
OP: You may be misinterpreting the purpose of the code comment as it's not an unresolved question of doubt but more a statement of function. The comment describes the effect the variables have in the form of a question as they're binary choices, this may also be to clarify that the variables are boolean and not numeric as one may think when seeing them in isolation at a use site or in IDE tooling. |
|
Thank you Lars for kindly clarifying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that you left this unanswered question in your source code, I believe it deserved to be answered for the people who stumble across it in the future.