Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add additional example for setting baseURL and cdnURL #27273

Merged
merged 3 commits into from
May 21, 2024

Conversation

itchina110
Copy link
Contributor

Correct the Example of baseURL and cdnURL

馃敆 Linked issue

馃摎 Description

Correct the Example of baseURL and cdnURL
Copy link

stackblitz bot commented May 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label May 19, 2024
@manniL
Copy link
Member

manniL commented May 19, 2024

Using environment variables to set these values should work and is correct I think 馃

@danielroe
Copy link
Member

The example should be correct. If it is not working for you, would you mind opening an issue with a reproduction? 馃檹

@danielroe danielroe closed this May 19, 2024
@itchina110
Copy link
Contributor Author

As a beginner with Nuxt, I find the documentation at "Nuxt Configuration" suggesting configuration in the nuxt.config.ts file. However, the examples for baseURL and cdnURL in the documentation are clearly not suitable for nuxt.config.ts. This can be very confusing for beginners. I believe the official documentation should be improved to consider various scenarios and provide clear descriptions.

@danielroe danielroe reopened this May 21, 2024
@danielroe
Copy link
Member

Understood! I've updated the PR so it adds an extra example rather than removing the one about overriding at runtime.

@danielroe danielroe changed the title Update app.ts, Correct the Example of baseURL and cdnURL docs: add additional example for setting baseURL and cdnURL May 21, 2024
@danielroe danielroe merged commit c0b3d03 into nuxt:main May 21, 2024
58 of 59 checks passed
@github-actions github-actions bot mentioned this pull request May 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants