Handle polars panics during collect #12866
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sholderbach
requested changes
May 14, 2024
There was a problem hiding this comment.
Can polars join check the preconditions in a sound way to avoid #12732?
Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
This reverts commit 69ed54b.
|
I noticed my comment to this is a bit buried in the suggestion thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When polars panics it will kill the instance of the plugin, causing all internal cached state to be lost. This most often happens when a collect operation is performed. This pull request wraps all collect panics in a panic handler.
related: #12732