-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests on minimal versions #12765
base: main
Are you sure you want to change the base?
Conversation
Is this a real problem?
|
Thanks for working on this, this seems like a good sanity check, not sure if we should do this on |
See nushell#12765 and h/t to @FMotalleb in https://discord.com/channels/601130461678272522/855947301380947968/1236286905843454032 `Duration/TimeDelta::try_milliseconds` was added in `0.4.34` https://github.com/chronotope/chrono/releases/tag/v0.4.34
Please guide me what to do next. |
See #12765 and h/t to @FMotalleb in https://discord.com/channels/601130461678272522/855947301380947968/1236286905843454032 `Duration/TimeDelta::try_milliseconds` was added in `0.4.34` https://github.com/chronotope/chrono/releases/tag/v0.4.34
I probably have to think about it a bit more to really have good advice on how we need to set up all the different jobs:
In the mean time can you rebase this branch onto main after |
Done 🍏
|
Description
From the problem in #12762