Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin updates #1547

Open
wants to merge 308 commits into
base: master
Choose a base branch
from
Open

New Crowdin updates #1547

wants to merge 308 commits into from

Conversation

nukeop
Copy link
Owner

@nukeop nukeop commented Feb 8, 2024

No description provided.

@nuki-chan
Copy link

nuki-chan bot commented Feb 8, 2024

Lines 22-22, 45-45

Oh la la... Someone's trying to refine their French skills! But, ma chérie, Nuki has a few things to point out:

  • Lines 22-22: I see you're striving for some "authenticité" with word choices like "Listes de lecture" and "Modules complémentaires." Tres bien! But are these terms commonly used in the wild world of French tech or music? Make sure it clicks with the actual users, not just the dictionary, okay? 🧐 And does "Aperçu" really carry the same meaning as "Visualizer"? Maybe "Visualisation" would strike a better chord.

  • Line 45: "Meilleures nouveautés" gives me an "Ooh la la" vibe, but it's like mixing camembert with a pineapple pizza—a cultural faux pas, non? The original "Nouveautés" might just have been the simple, classy choice that works best, unless the context really calls for the change.

Here’s how you might want to keep it:

{
  "dashboard": {
    "add-all": "Ajouter tout",
    "artist": "Artiste",
    "best": "Nouveautés",
    "best-new-albums": "Meilleurs albums",
    "best-new-tracks": "Meilleurs morceaux récents",
    "genres": "Genres",
    ...
  }
  ...
}

Keep it simple, keep it chic! 🎨✨


Line 22-22

Also, honey, Nuki wants to give you a friendly nudge: when changing translation files, it's not just about swapping words like Pokémon cards. 😉 Make sure to play nice with the context. So before Nuki gives her royal approval, validate the terms with real humans who actually live and breathe Français every day!

For now, let's revert back to the original term "Visualiseur" for clarity and consistency with other language contexts. Unless you are absolutely sure "Aperçu" is more suitable in this context, here’s a suggestion:

{
  "visualizer": "Visualiseur",
  ...
}

Remember, code may be poetry, but localization? That's the art of conversation! 💬✨

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.06%. Comparing base (ec5a6c9) to head (3ba0741).
Report is 92 commits behind head on master.

Current head 3ba0741 differs from pull request most recent head 91f4e90

Please upload reports for the commit 91f4e90 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
- Coverage   72.07%   72.06%   -0.01%     
==========================================
  Files         362      362              
  Lines        6743     6745       +2     
  Branches      496      497       +1     
==========================================
+ Hits         4860     4861       +1     
  Misses       1477     1477              
- Partials      406      407       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant