-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node): Enable e2e test #23508
base: master
Are you sure you want to change the base?
fix(node): Enable e2e test #23508
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 261ec16. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
be7fcdc
to
419e05c
Compare
419e05c
to
d80fd07
Compare
d80fd07
to
72421e3
Compare
72421e3
to
885f723
Compare
@@ -30,15 +28,16 @@ function normalizeOptions( | |||
} | |||
|
|||
function addDocker(tree: Tree, options: SetUpDockerOptions) { | |||
// Inferred targets are only available in the project graph | |||
const projectConfig = readCachedProjectConfiguration(options.project); | |||
const projectConfig = readProjectConfiguration(tree, options.project); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't include inferred targets...
Shouldn't we still be able to setup docker for projects with inferred build targets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not?
- If the project has not been created yet, reading from the graph would be invalid right?
- The
tree
is passed in as an argument, which is probably the source of truth for generators.
The current setup should work for both crystal and non-inferred projects.
885f723
to
261ec16
Compare
Re-enables e2e tests for node