Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): clean up show project --json false #23486

Merged

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented May 17, 2024

Current Behavior

Screenshot 2024-05-27 at 1 54 08 PM

Expected Behavior

Related Issue(s)

Fixes #

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 5:22pm

@xiongemi xiongemi force-pushed the feature/nxc-203-cleanup-nx-show-text-view branch 2 times, most recently from c605e61 to b717292 Compare May 22, 2024 01:08
@xiongemi xiongemi changed the title Feature/nxc 203 cleanup nx show text view feat(core): clean up show project --json false May 22, 2024
@xiongemi xiongemi marked this pull request as ready for review May 22, 2024 01:09
@xiongemi xiongemi requested a review from a team as a code owner May 22, 2024 01:09
@xiongemi xiongemi requested a review from AgentEnder May 22, 2024 01:09
@xiongemi xiongemi force-pushed the feature/nxc-203-cleanup-nx-show-text-view branch from b717292 to a2ec7d0 Compare May 22, 2024 16:43
@xiongemi xiongemi force-pushed the feature/nxc-203-cleanup-nx-show-text-view branch from a2ec7d0 to d973a05 Compare May 23, 2024 18:11
@xiongemi xiongemi force-pushed the feature/nxc-203-cleanup-nx-show-text-view branch from d973a05 to 535a2ba Compare May 27, 2024 14:58
@xiongemi xiongemi force-pushed the feature/nxc-203-cleanup-nx-show-text-view branch from 535a2ba to d025436 Compare May 27, 2024 17:20
@FrozenPandaz FrozenPandaz merged commit a7c5603 into nrwl:master May 27, 2024
6 checks passed
ndcunningham pushed a commit that referenced this pull request May 28, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

<img width="657" alt="Screenshot 2024-05-27 at 1 54 08 PM"
src="https://github.com/nrwl/nx/assets/16211801/b66bbf57-1d75-485f-bf8e-17a28579a7e5">

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
FrozenPandaz pushed a commit that referenced this pull request May 28, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->

<img width="657" alt="Screenshot 2024-05-27 at 1 54 08 PM"
src="https://github.com/nrwl/nx/assets/16211801/b66bbf57-1d75-485f-bf8e-17a28579a7e5">

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit a7c5603)
Copy link

github-actions bot commented Jun 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants