cleanup(react): improved error message throwed when executor is not available or not valid #23282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vailable or not valid The error message which is throwed when executer is not available or not valid is really confusing. Hence updating it to throw the exact issue why it errored
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bab82d5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
ndcunningham
approved these changes
May 29, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 3, 2024
…vailable or not valid (#23282) The error message which is throwed when executer is not available or not valid is really confusing. Hence updating it to throw the exact issue why it errored. <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior The error message throwed is really vauge. And does't really tell anything about why it happened. Fixes # Improved error message which is throwed when excuter is not valid or not present in the project.json <img width="1421" alt="Screenshot 2024-05-10 at 1 17 05 AM" src="https://github.com/nrwl/nx/assets/54993680/455163e4-3197-419c-b511-040c35784a72"> (cherry picked from commit eb44f9b)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message which is throwed when executer is not available or not valid is really confusing. Hence updating it to throw the exact issue why it errored.
Current Behavior
The error message throwed is really vauge. And does't really tell anything about why it happened.
Fixes #
Improved error message which is throwed when excuter is not valid or not present in the project.json