installer script: fix detection of macOS on newer QtIFW #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the offline installer for GPT4All v2.8.0-pre1 created
GPT4All.desktopinstead of the symlink in the applications folder.According to the QtIFW docs, systemInfo is always "macos" on macOS, not "osx".
This PR updates the installer script to also recognize "macos". This bug has presumably existed since at least #2015, when QtIFW was updated in CI. I have no idea which version of QtIFW is used to make the online installers, so I am keeping the "osx" check for backwards compatibility.