-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --skip-prelude
hidden CLI option
#5033
base: master
Are you sure you want to change the base?
Conversation
@@ -250,12 +254,14 @@ pub fn check_crate( | |||
deny_warnings: bool, | |||
disable_macros: bool, | |||
use_elaborator: bool, | |||
skip_prelude: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably be good to start grouping these together. It looks like in a lot of tests we just have four false
variables being passed through.
Maybe we could put these options on the Context
to easily thread them to other passes as well. This is non-blocking but just a thought
@michaeljklein I see you marked this as a draft? Is this to add a |
If this is ready I'd like it as well for testing the elaborator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Michael's out today so I'm going to merge this. |
--skip-prelude
hidden CLI option, skip inject_prelude
when true--skip-prelude
hidden CLI option
Merge queue setting changed
Description
Problem*
Usually, when debugging programs, they can be converted to a
noirc_frontend/tests.rs
test with or without including the stdlib/prelude.However, workspace and multi-file-specific cases can be tedious to debug when the failing file has ~10 LOC and most of the context / parsing / type checking / etc. is all stdlib.
Summary*
Adds
--skip-prelude
flag to skip callinginject_prelude
when collecting definitions.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.