Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: avoid error when coverage line not found #53000

Merged
merged 1 commit into from
May 17, 2024
Merged

test_runner: avoid error when coverage line not found #53000

merged 1 commit into from
May 17, 2024

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented May 15, 2024

Fixes: #52775

the coverage in this case is pretty useless, but it wont throw after this fix

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner labels May 15, 2024
@RedYetiDev RedYetiDev mentioned this pull request May 15, 2024
Closed
@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2024
@MoLow
Copy link
Member Author

MoLow commented May 15, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/59226/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59228/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2024
@nodejs-github-bot nodejs-github-bot merged commit d4442a9 into nodejs:main May 17, 2024
43 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d4442a9

@MoLow MoLow deleted the coverage-dont-throw-if-line-not-found branch May 19, 2024 07:14
targos pushed a commit that referenced this pull request May 21, 2024
@MoLow @targos
test_runner: avoid error when coverage line not found
e2211a0 
PR-URL: #53000
Fixes: #52775
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
lukins-cz pushed a commit to lukins-cz/OS-Aplet-node that referenced this pull request Jun 1, 2024
@MoLow @lukins-cz
test_runner: avoid error when coverage line not found
65e2292 
PR-URL: nodejs#53000
Fixes: nodejs#52775
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Experimental Test Coverage throws "cannot read properties of undefined (reading: line)"
6 participants
@MoLow @nodejs-github-bot @benjamingr @anonrig @cjihrig @atlowChemi