Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ruff cleanup #2779

Merged
merged 14 commits into from
May 18, 2024
Merged

chore: ruff cleanup #2779

merged 14 commits into from
May 18, 2024

Conversation

RazCrimson
Copy link
Collaborator

Fixes all formatting by ruff

@nicolargo
Should we add something like precommit tooling that automatically runs ruff on each and every commit?

Something like would be nice: https://github.com/pre-commit/pre-commit

@nicolargo
Copy link
Owner

Why not, there is some examples here: https://github.com/astral-sh/ruff?tab=readme-ov-file#installation

We just have to take into account the following thinks in this PR:

glances/client.py Fixed Show resolved Hide resolved
glances/password.py Dismissed Show dismissed Hide dismissed
@RazCrimson
Copy link
Collaborator Author

@nicolargo
Could you give this a spin on your end?

I've just enabled some of the easy to fix lint rules that should not change any behavior.
Enabling all of them would require a lot more changes than this.

I think it would be better to enable the others slowly over other releases as they would require more invasive code changes.

… the venv* folders in the linter configuration
@nicolargo
Copy link
Owner

Review ok on my side, i have to reconfigure my VSCode to set Ruff as the default Linter (instead of Flake8). I just push some minors changes.

PR can be pushed on develop.

@nicolargo nicolargo merged commit a99bf33 into develop May 18, 2024
17 of 20 checks passed
@nicolargo nicolargo added this to the Glances 4.0.5 milestone May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants