Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hasura-auth-js): resolve social sign-in issue in React Native #2716

Merged
merged 3 commits into from
May 20, 2024

Conversation

onehassan
Copy link
Contributor

fix #2216

@onehassan onehassan self-assigned this May 16, 2024
@onehassan onehassan requested a review from nunopato as a code owner May 16, 2024 15:02
Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dashboard-staging ✅ Ready (Inspect) Visit Preview May 20, 2024 10:35am
example-nextjs-server-components ✅ Ready (Inspect) Visit Preview May 20, 2024 10:35am
example-react-apollo ✅ Ready (Inspect) Visit Preview May 20, 2024 10:35am
example-sveltekit ✅ Ready (Inspect) Visit Preview May 20, 2024 10:35am
example-vue-apollo ✅ Ready (Inspect) Visit Preview May 20, 2024 10:35am
1 Ignored Deployment
Name Status Preview Updated (UTC)
dashboard ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 10:35am

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 584dc06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@nhost/hasura-auth-js Patch
@nhost/nhost-js Patch
@nhost-examples/vue-apollo Patch
@nhost/react Patch
@nhost/vue Patch
@nhost/apollo Patch
@nhost-examples/cli Patch
@nhost-examples/multi-tenant-one-to-many Patch
@nhost-examples/node-storage Patch
@nhost-examples/nextjs-server-components Patch
@nhost/nextjs Patch
@nhost/react-apollo Patch
@nhost/react-urql Patch
@nhost-examples/codegen-react-apollo Patch
@nhost-examples/codegen-react-query Patch
@nhost-examples/codegen-react-urql Patch
@nhost-examples/nextjs Patch
@nhost-examples/react-apollo Patch
@nhost-examples/react-gqty Patch
@nhost-examples/vue-quickstart Patch
@nhost/dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dbarrosop
Copy link
Contributor

I think a better changelog would be "improve environment/browser detect to include react-native"

@onehassan
Copy link
Contributor Author

improve environment/browser detect to include react-native

Thanks will apply

@hadnet
Copy link

hadnet commented May 28, 2024

So now oauth is now working using React Native?

@dbarrosop
Copy link
Contributor

it will when we release this fix. We are finishing up an example/documentation as we speak so stay tuned :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk SDK package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign in with apple is doesn't work with react native
4 participants