fix(system): missing useHref logic

[wingkwong]

📝 Description

Patch the missing logic due to the previous react aria upgrade

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

• Bug Fixes

  • Fixed missing useHref logic in the UI system package.
  • Updated routing functions to handle additional parameters and enhanced navigation checks.

• New Features

  • Enhanced autocomplete functionality by allowing null values in selection changes.

• Documentation

  • Revised and restructured routing guide documentation for improved clarity and accessibility.

• Dependency Updates

  • Updated @react-types/shared to version 3.23.0 across multiple packages.

[linear]

ENG-783 [BUG] - Cannot read properties of undefined (reading 'startsWith')

[changeset-bot]

🦋 Changeset detected

Latest commit: abc50bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages

Name	Type
@nextui-org/system	Patch
@nextui-org/pagination	Patch
@nextui-org/use-aria-link	Patch
@nextui-org/use-aria-menu	Patch
@nextui-org/accordion	Patch
@nextui-org/autocomplete	Patch
@nextui-org/calendar	Patch
@nextui-org/date-picker	Patch
@nextui-org/dropdown	Patch
@nextui-org/link	Patch
@nextui-org/listbox	Patch
@nextui-org/menu	Patch
@nextui-org/modal	Patch
@nextui-org/navbar	Patch
@nextui-org/popover	Patch
@nextui-org/select	Patch
@nextui-org/slider	Patch
@nextui-org/snippet	Patch
@nextui-org/tabs	Patch
@nextui-org/tooltip	Patch
@nextui-org/react	Patch
@nextui-org/aria-utils	Patch
@nextui-org/framer-utils	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !pnpm-lock.yaml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent changes aim to improve routing and link functionalities across various parts of the codebase, addressing reported bugs related to navigation issues, updating dependencies for compatibility, and refining how href and routerOptions are handled in link-related functions.

Changes

File Path	Summary
.changeset/curvy-eels-tap.md packages/core/system/src/provider.tsx	Introduced useHref logic in @nextui-org/system.
.changeset/friendly-months-tease.md packages/components/pagination/src/... packages/hooks/use-aria-link/src/index.ts packages/hooks/use-aria-menu/src/...	Updated dependency versions, enhanced navigation handling by checking props.href, and added props.routerOptions to router.open.
apps/docs/app/examples/autocomplete/...	Modified onSelectionChange to accept an additional null type for key.
apps/docs/content/docs/guide/routing.mdx	Adjusted header levels for routing documentation.
package.json packages/hooks/use-aria-menu/package.json	Updated @react-types/shared from 3.22.1 to 3.23.0.

Assessment against linked issues

Objective	Addressed	Explanation
Fix navigation error when clicking links (#2934, #2930)	✅	-
Ensure proper function of NextUIProvider with useRouter in various setups (#2934, #2941, #2930)	✅	-
Update dependencies to match new router functionalities (#2941)	✅	-
Address undefined path error in NextUIProvider (#2930)	❓	The changes seem to address navigation issues, but more information is needed to confirm if the specific path is undefined error is resolved.
Ensure all linked components properly utilize routerOptions (#2941)	✅	-

These updates are crucial for maintaining the functionality and user experience of applications using these packages, particularly in terms of navigation and link management.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 5, 2024 4:45am
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 5, 2024 4:45am

[coderabbitai]

Actionable comments posted: 2

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c0cf7dd and 7d4b1a5.

Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !pnpm-lock.yaml

Files selected for processing (1)

• packages/hooks/use-aria-menu/package.json (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• packages/hooks/use-aria-menu/package.json