Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dav): implement event to trigger updating the resources/rooms cache #45380

Closed
wants to merge 1 commit into from

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented May 16, 2024

  • Resolves: none

Summary

Ref nextcloud/calendar_resource_management#124

Provide a public event and listener to allow updating rooms and resources (almost) instantly instead of waiting up to an hour.

Checklist

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the feat/update-rooms-resources-event branch from a247e59 to a580840 Compare May 27, 2024 07:37
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 27, 2024
@st3iny st3iny added this to the Nextcloud 30 milestone May 27, 2024
@st3iny st3iny marked this pull request as ready for review May 27, 2024 07:39
*
* @since 30.0.0
*/
class ScheduleResourcesRoomsUpdateEvent extends Event {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class ScheduleResourcesRoomsUpdateEvent extends Event {
class ScheduleResourcesRoomsUpdatedEvent extends Event {

the event should signal that something happened, not the intent

https://docs.nextcloud.com/server/latest/developer_manual/basics/events.html#naming-scheme

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this a real public API we can move the events to OCP\Calendar\Resource

As an alternative to the event approach you could also consider an explicit method on \OCP\Calendar\Resource\IManager.

@st3iny st3iny marked this pull request as draft May 27, 2024 16:11
@st3iny st3iny closed this May 28, 2024
@st3iny st3iny deleted the feat/update-rooms-resources-event branch May 28, 2024 12:00
@st3iny st3iny removed this from the Nextcloud 30 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement feature: caldav Related to CalDAV internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants