Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move EventSource to OC namespace #45375

Merged
merged 2 commits into from
May 21, 2024
Merged

Move EventSource to OC namespace #45375

merged 2 commits into from
May 21, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented May 16, 2024 •
edited

Summary

There is an interface for it and a factory in OCP, so there’s no need to keep it in legacy folder.

Checklist

@come-nc
fix: Move OC_EventSource to OC namespace
a9f7131 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix: Improve code quality in EventSource
d7ed056 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added 3. to review Waiting for reviews technical debt labels May 16, 2024
@come-nc come-nc added this to the Nextcloud 30 milestone May 16, 2024
@come-nc come-nc requested review from kesselb and a team May 16, 2024 15:35
@come-nc come-nc self-assigned this May 16, 2024
@come-nc come-nc requested review from icewind1991, yemkareems and sorbaugh and removed request for a team May 16, 2024 15:35
@come-nc come-nc merged commit 9b0e483 into master May 21, 2024
155 checks passed
@come-nc come-nc deleted the fix/move-eventsource-to-oc branch May 21, 2024 07:11
@come-nc come-nc added the pending documentation This pull request needs an associated documentation update label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@kesselb kesselb kesselb approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update technical debt
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@come-nc @susnux @kesselb