Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(user_ldap): Do not map groups we do not know if they match filter #45364

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented May 16, 2024

  • Resolves: #

Summary

When nesting is enabled, filterValidGroups is supposed to check for each groups if it actually exist, because it may not be visible to Nextcloud. So in this codepath we disable automapping of groups.

That may mean in some cases we do not map a valid group, but it should get mapped sooner or later anyway.
I’m still pondering if this is the best solution.

  • Maybe only do that if nesting is enabled? Not clear to me yet if this is the only possible problematic case
  • Maybe only do that if $name is not null, as when it is null a search will be used to validate existence anyway.
  • If this last point is true, maybe we simply always pass null for $name? Or pass null for $name when nesting is enabled?

Checklist

When nesting is enabled, filterValidGroups is supposed to check for each
 groups if it actually exist, because it may not be visible to
 Nextcloud. So in this codepath we disable automapping of groups.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added this to the Nextcloud 30 milestone May 16, 2024
@come-nc come-nc requested a review from blizzz May 16, 2024 12:43
@come-nc come-nc self-assigned this May 16, 2024
@come-nc come-nc marked this pull request as draft May 16, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant