Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support excalidraw file #45353

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

hweihwang
Copy link

Summary

  • Support new excalidraw file type

@hweihwang hweihwang self-assigned this May 16, 2024
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@hweihwang hweihwang force-pushed the feat/excalidraw-file-support branch from 29f881f to 8b84fe9 Compare May 16, 2024 10:41
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@hweihwang hweihwang force-pushed the feat/excalidraw-file-support branch from c0e470a to a7fb83f Compare May 17, 2024 02:42
@@ -106,6 +106,14 @@ private function updateMimetypes($updatedMimetypes) {
return $count;
}

private function introduceExcalidrawType() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be an opportunity to add return type hint here and in updateMimetypes()

Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@hweihwang hweihwang requested a review from blizzz May 20, 2024 09:26
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants