Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] Avoid updating the same oc_authtoken row twice #45351

Merged
merged 3 commits into from
Jun 4, 2024
Merged

[stable27] Avoid updating the same oc_authtoken row twice #45351

merged 3 commits into from
Jun 4, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented May 16, 2024 •
edited by kesselb

@backportbot backportbot bot added this to the Nextcloud 27.1.10 milestone May 16, 2024
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 16, 2024
ChristophWurst
ChristophWurst previously requested changes May 16, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#45026 (comment)

@ChristophWurst ChristophWurst marked this pull request as draft May 21, 2024 06:17
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels May 21, 2024
@kesselb kesselb force-pushed the backport/45026/stable27 branch 2 times, most recently from 8fa835d to 2ed43c9 Compare May 29, 2024 12:27
@kesselb kesselb marked this pull request as ready for review June 3, 2024 17:22
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 3, 2024
@juliushaertl @kesselb
docs: Update token_auth_activity_update default value to match implem…
fa5360c 
…entation

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl @kesselb
fix: Always set last activity if we update the row of an authtoken an…
2a6116e 
…yways

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@ChristophWurst @kesselb
fix(auth): Update authtoken activity selectively
0cc6928 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@AndyScherzinger AndyScherzinger merged commit 3c0479d into stable27 Jun 4, 2024
37 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/45026/stable27 branch June 4, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Altahrim Altahrim Altahrim approved these changes

@kesselb kesselb kesselb approved these changes

@joshtrichards joshtrichards Awaiting requested review from joshtrichards

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@juliushaertl juliushaertl

Labels
3. to review Waiting for reviews enhancement feature: authentication performance 🚀
Projects
None yet
Milestone
Nextcloud 27.1.11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ChristophWurst @Altahrim @kesselb @AndyScherzinger @juliushaertl