Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only list remnants as disabled if option is enabled #45347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented May 16, 2024

Summary

In 28 a new config option was added to consider remnants as disabled users.
But they were appearing in the list of disabled users even if the new option was not used, which can be confusing.

With this PR remnants are back at being ghosts by default and will only appear in disabled user list if the option is checked.
One problem is that the option is only checked on the first LDAP configuration and applied to all of them regarding to listing disabled users, because there is no efficient way to do otherwise (all remnants are in the same place). We already have this kind of trick for other things and expect that LDAP configurations are not too different from one another on the same server usually.

Checklist

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added 3. to review Waiting for reviews feature: ldap labels May 16, 2024
@come-nc come-nc added this to the Nextcloud 30 milestone May 16, 2024
@come-nc come-nc requested review from blizzz and Pytal May 16, 2024 09:04
@come-nc come-nc self-assigned this May 16, 2024
@Pytal Pytal enabled auto-merge May 16, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants