Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix Media Item Delete Crash #13016

Merged
merged 11 commits into from
May 21, 2024
Merged

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented May 16, 2024

  • Tests written, or not not needed

What This PR Does

  1. Actual crash fix for media item delete
  2. ViewPager to ViewPager2 Migration
  3. PreviewImagePagerAdapter converted to the Kotlin
  4. Remove CustomViewPager

@ZetaTom
Copy link
Collaborator

ZetaTom commented May 17, 2024

I've pushed a few changes to fix scrolling in the view pager.

@ZetaTom ZetaTom requested review from JonasMayerDev and removed request for ZetaTom May 17, 2024 07:52
@alperozturk96 alperozturk96 force-pushed the bugfix/media-item-delete-crash branch from 4d9322c to 364e031 Compare May 17, 2024 07:54
alperozturk96 and others added 10 commits May 21, 2024 09:26
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the bugfix/media-item-delete-crash branch from 69a6796 to 11139e4 Compare May 21, 2024 07:26
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link

Codacy

Lint

TypemasterPR
Warnings7272
Errors33

SpotBugs

CategoryBaseNew
Bad practice6664
Correctness7069
Dodgy code349347
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5757
Security1919
Total577572

Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13016.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link
Collaborator

@JonasMayerDev JonasMayerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@alperozturk96 alperozturk96 merged commit 4ecce01 into master May 21, 2024
21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/media-item-delete-crash branch May 21, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants