-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create individual workers for every Autoupload Folder #13015
Create individual workers for every Autoupload Folder #13015
Conversation
d011ec9
to
49103a7
Compare
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
Signed-off-by: Jonas Mayer <jonas.a.mayer@gmx.net>
bbc8743
to
d91b652
Compare
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13015.apk |
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13015-Screenshot-blue-Light-18-26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. I created 3 folder set auto upload and only 3 worker created for each auto upload and all uploads successfully completed.
This PR finally gets rid of the foreground worker and the corresponding notification by lowering the chance the worker gets killed.
Internally, the app now starts a new worker for every auto upload folder instead of one worker for all folders.
Advantages are:
The best way to test is using logcat and filtering for "File sync" since all important log messages start with that term. Like this, you should be able to observe the behavior of the background worker without messing with it. If you want to check something specific, use the debugger, but be aware that that changes behavior (like execution speed).