Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(l10n): grammar fixes for plural usage #13002

Merged
merged 2 commits into from
May 22, 2024
Merged

fix(l10n): grammar fixes for plural usage #13002

merged 2 commits into from
May 22, 2024

Conversation

roliverio
Copy link
Contributor

  • Tests written, or not not needed

Fix plural usage and word positioning on the changed strings. Hinders translation on some verb forms in other languages.

ZetaTom
ZetaTom reviewed May 13, 2024
View reviewed changes
Copy link
Collaborator

@ZetaTom ZetaTom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, thank you for taking the time to implement these changes.

All the changes to the log messages look good. I've also left a few comments with some suggestions.

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-b+en+001/strings.xml Outdated Show resolved Hide resolved
@roliverio roliverio requested a review from ZetaTom May 15, 2024 16:01
@roliverio
Copy link
Contributor Author

@ZetaTom I've reverted the changes on values-*, implemented your suggestion also on the other file. Let me know if it looks right!

@roliverio @alperozturk96
fix(l10n): grammar fixes for plural usage
5dd3da5 
Signed-off-by: Julio C. Ortega <390821+roliverio@users.noreply.github.com>
@roliverio @alperozturk96
fix(l10n): grammar fixes for plural usage
ea42cfe 
Signed-off-by: Julio C. Ortega <390821+roliverio@users.noreply.github.com>
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.30.0 milestone May 22, 2024
@AndyScherzinger
Copy link
Member

/backport to stable-3.29

@AndyScherzinger AndyScherzinger merged commit ac3a8f6 into nextcloud:master May 22, 2024
21 checks passed
@backportbot backportbot bot mentioned this pull request May 22, 2024
Merged
@AndyScherzinger
Copy link
Member

Thanks a lot @roliverio 🎉 - merged and backported 👍

@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes

@ZetaTom ZetaTom ZetaTom approved these changes

Assignees
No one assigned
Labels
3. to review feedback-requested
Projects
None yet
Milestone
Nextcloud App 3.30.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roliverio @AndyScherzinger @alperozturk96 @ZetaTom