Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wording in aio-config.twig #4660

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ncguk
Copy link
Contributor

@ncguk ncguk commented May 16, 2024

Small improvements to text. No code changes.

Small improvements to text. No code changes.

Signed-off-by: ncguk <inglenook@duck.com>
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels May 16, 2024
@szaimen szaimen added this to the next milestone May 16, 2024
You can run Nextcloud's usual occ commands by following the <a href="https://github.com/nextcloud/all-in-one#how-to-run-occ-commands">occ documentation</a></b>.<br><br>
{% endif %}

{% if nextcloud_datadir starts with '/' %}
Nextcloud's datadir is getting stored in the {{ nextcloud_datadir }} directory.
Nextcloud's datadir is stored in the {{ nextcloud_datadir }} directory.
Copy link
Collaborator

@szaimen szaimen May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just one remark:

Actually, during the initial installation, the data is not stored yet. Only after finishing it. That is why this kind of wording was chosen. What would you suggest to improve this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I would suggest then that the wording be "Nextcloud's datadir will be stored in the {{ nextcloud_datadir }} directory."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm... I fear this doesnt work after the instance is installed then? (this template is used in both cases...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I see what you mean.

"Nextcloud backups will be saved to {{ nextcloud_datadir }}." works for both a first back up and subsequent backups that have yet to be made. You could also have:

"All Nextcloud backups will be saved to {{ nextcloud_datadir }}."
"Your Nextcloud backups will be saved to {{ nextcloud_datadir }}."
"All of your Nextcloud backups will be saved to {{ nextcloud_datadir }}."
"Once you have made your first backup it, and all subsequent backups, will be stored in {{ nextcloud_datadir }}."

@szaimen szaimen changed the title Update aio-config.twig Update wording in aio-config.twig May 17, 2024
@szaimen szaimen modified the milestones: v8.3.0, next May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants