Add a config option for the postgres database port #4433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #3631, with most comments addressed.
The last open point of discussion was whether it makes sense to add the
POSTGRES_PORT
config option to the AiO Postgres container. I don't think so, and wrote:This PR has been tested using these steps:
nextcloud
andnotify-push
containers manuallyoc_
, as that is hardcoded at various places)compose.yml
nextcloud-aio-database
container and the dependency fromnextcloud-aio-nextcloud
to itPOSTGRES_HOST
,POSTGRES_PORT
,POSTGRES_HOST
andPOSTGRES_DB
environment variables for the nextcloud and notify-push containers. Note thatPOSTGRES_USER
must not include theoc_
prefix, whilePOSTGRES_DB
needs to contain it.docker compose up
should then set up a new Nextcloud using the external database