Add keycloak as default example provider. #10874
Conversation
falcowinkler
requested review from
ubbe-xyz,
ndom91 and
ThangHuuVu
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@falcowinkler is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10874 +/- ##
==========================================
+ Coverage 37.51% 37.81% +0.30%
==========================================
Files 173 173
Lines 26983 26983
Branches 1176 1182 +6
==========================================
+ Hits 10122 10204 +82
+ Misses 16861 16779 -82 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I'd prefer we don't add this.
The user doesn't have access to the IdP, so they can't add users or anything anyway, so they'll just end up deleting it rather quickly. If we just want to show them a demo, we have the hosted example apps. Plus this way we're sharing the Keycloak secret (which we already are "leaking" through this PR 😅). I get its not that important and they can't do much with it, but yeah still not great imo
|
hey, |
☕️ Reasoning
Since we now have our own "dummy" provider, people can get started with the example project much easier.
If we configure this dummy provider by default, you just have to run the app and use keycloak to log in. Then also the client-example will work right out of the box.
🧢 Checklist
🎫 Affected issues
📌 Resources