Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers): add SimpleLogin oidc #10491

Merged
merged 10 commits into from
Jun 1, 2024

Conversation

alexaka1
Copy link
Contributor

@alexaka1 alexaka1 commented Apr 6, 2024

☕️ Reasoning

Adds Sign in with SimpleLogin support.

SimpleLogin is built for privacy-conscious site owners and protects your users identity. Open-source, Developer-first, SimpleLogin can be integrated in minutes.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Apr 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2024 10:55am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2024 10:55am

Copy link

vercel bot commented Apr 6, 2024

@alexaka1 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@alexaka1
Copy link
Contributor Author

alexaka1 commented Apr 6, 2024

I am not sure what tests are necessary. I have tested the code with my own website, and users are able to log in with SimpleLogin. I would love some input from a maintainer about tests.

@ndom91
Copy link
Member

ndom91 commented May 12, 2024

This looks pretty good already! Can you add a docs page at /docs/pages/getting-started/providers/simplelogin.mdx?

Thanks 🙏

@alexaka1
Copy link
Contributor Author

I have included an mdx.

@ndom91
Copy link
Member

ndom91 commented May 19, 2024

Two minor nit picks,

  1. Is the brand color really #fff? Maybe lets go with their pink-ish color from the logo
  2. There seems to be a prettier issue in your mdx file (docs/pages/getting-started/providers/simplelogin.mdx)

@alexaka1
Copy link
Contributor Author

Tbh, I couldn't figure out what the brand color does. But will get them fixed.

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 107 lines in your changes are missing coverage. Please review.

Project coverage is 40.75%. Comparing base (f1bf7ae) to head (bed93e1).

Current head bed93e1 differs from pull request most recent head b39ad83

Please upload reports for the commit b39ad83 to get more accurate results.

Files Patch % Lines
packages/core/src/providers/simplelogin.ts 0.00% 107 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10491      +/-   ##
==========================================
- Coverage   40.91%   40.75%   -0.16%     
==========================================
  Files         176      177       +1     
  Lines       27924    28031     +107     
  Branches     1243     1244       +1     
==========================================
  Hits        11424    11424              
- Misses      16500    16607     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ndom91 and others added 4 commits May 27, 2024 04:19
Co-authored-by: Kawahara Shotaro <121674121+k-taro56@users.noreply.github.com>
Co-authored-by: Kawahara Shotaro <121674121+k-taro56@users.noreply.github.com>
Co-authored-by: Kawahara Shotaro <121674121+k-taro56@users.noreply.github.com>
@ndom91 ndom91 merged commit 0b321a0 into nextauthjs:main Jun 1, 2024
10 of 11 checks passed
@alexaka1 alexaka1 deleted the simplelogin-provider branch June 1, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants