Simplify and unify the way we are handling versions. #17693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now `program_version` is only used for getting or setting the host's field.
vkalintiris
requested review from
a team,
thiagoftsm,
Ferroin and
stelfrag
as code owners
github-actions
bot
added
area/packaging
Ferroin
reviewed
May 17, 2024
Ferroin
reviewed
May 17, 2024
Ferroin
reviewed
May 17, 2024
Ferroin
previously approved these changes
May 22, 2024
|
Hello @vkalintiris , Compiling on Linux I have this error: /home/thiago/Netdata/tests_netdata/src/collectors/ebpf.plugin/ebpf.c:3252:44: error: 'VERSION' undeclared (first use i
n this function); did you mean 'CMD_VERSION'?
3252 | printf("ebpf.plugin %s\n", VERSION); |
thiagoftsm
requested changes
May 22, 2024
thiagoftsm
added a commit
to thiagoftsm/netdata
that referenced
this pull request
May 23, 2024
thiagoftsm
previously approved these changes
May 23, 2024
thiagoftsm
approved these changes
May 23, 2024
thiagoftsm
added a commit
to thiagoftsm/netdata
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes the individual version fields available to C, which will allow us to track versions better with Sentry.
Test Plan
cpack -G DEBand check filenames.